Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

172 - "My account" should be "My Account" #36

Closed
wants to merge 1 commit into from

Conversation

A-Souhei
Copy link
Contributor

Description

Only updates "My account" to "My Account" in top navbar.

Note that there are other instances of "My account" in:

  • footer
  • dashboard breadcrumbs including sysadmin
    Shall I update all of them?

image

Closes fjelltopp/zarr-ckan#172

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Sep 25, 2024
@A-Souhei A-Souhei added bug Something isn't working minor labels Sep 25, 2024
@A-Souhei A-Souhei marked this pull request as ready for review September 25, 2024 11:23
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update all of them.... and should that be here or Fjelltopp theme?

@A-Souhei A-Souhei closed this Sep 26, 2024
@A-Souhei A-Souhei deleted the 172-my-account-should-be-my-account branch September 26, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"My account" should be "My Account"
2 participants